Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109050: Remove remaining tests for legacy Unicode C API #109068

Merged
merged 3 commits into from
Sep 9, 2023
Merged

gh-109050: Remove remaining tests for legacy Unicode C API #109068

merged 3 commits into from
Sep 9, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 7, 2023 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Sep 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 7, 2023
Closed
@serhiy-storchaka serhiy-storchaka requested review from vstinner and removed request for rhettinger September 7, 2023 10:53
vstinner
vstinner approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor coding style remark.

Lib/test/test_capi/test_getargs.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) September 8, 2023 09:05
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) September 8, 2023 09:06
@serhiy-storchaka serhiy-storchaka merged commit b4131a1 into python:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @vstinner @bedevere-bot