Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109341: Fix crash on compiling invalid AST including TypeAlias #109349

Merged
merged 2 commits into from
Sep 13, 2023
Merged

gh-109341: Fix crash on compiling invalid AST including TypeAlias #109349

merged 2 commits into from
Sep 13, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 12, 2023 •
edited by bedevere-app bot
Loading

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label Sep 12, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 12, 2023
Closed
JelleZijlstra
JelleZijlstra commented Sep 12, 2023
View reviewed changes
Python/symtable.c Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 987b4bc into python:main Sep 13, 2023
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@JelleZijlstra JelleZijlstra deleted the astsegv branch September 13, 2023 16:00
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2023
@JelleZijlstra @miss-islington
pythongh-109341: Fix crash on compiling invalid AST including TypeAli…
d5331e2 
…as (pythonGH-109349)

(cherry picked from commit 987b4bc)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 13, 2023

GH-109381 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 13, 2023
Yhg1s pushed a commit that referenced this pull request Sep 14, 2023
@miss-islington @JelleZijlstra
[3.12] gh-109341: Fix crash on compiling invalid AST including TypeAl…
5c7e8c3 
…ias (GH-109349) (#109381)

gh-109341: Fix crash on compiling invalid AST including TypeAlias (GH-109349)
(cherry picked from commit 987b4bc)

Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra JelleZijlstra restored the astsegv branch September 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @miss-islington @serhiy-storchaka