gh-109549: Add new states to PyThreadState to support PEP 703 #109915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new field 'state' to PyThreadState that can take on one of three values: _Py_THREAD_ATTACHED, _Py_THREAD_DETACHED, and _Py_THREAD_GC. The "attached" and "detached" states correspond closely to closely to acquiring and releasing the GIL. The "gc" state is current unused, but will be used to implement stop-the-world GC for `--disable-gil` builds in the near future.
|
!buildbot nogil |
|
The regex 'nogil' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
|
!buildbot GIL |
|
The regex 'GIL' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
colesbury
commented
Sep 26, 2023
| @@ -2095,12 +2092,11 @@ new_interpreter(PyThreadState **tstate_p, const PyInterpreterConfig *config) | |||
| *tstate_p = NULL; | |||
|
|
|||
| /* Oops, it didn't work. Undo it all. */ | |||
| PyErr_PrintEx(0); | |||
There was a problem hiding this comment.
I removed the PyErr_PrintEx(0) call, which never printed anything (failures are reported via PyStatus) and was also unsafe to call in some cases when the current thread did not hold the GIL.
|
@ericsnowcurrently, would you please review this when you get a chance? |
ericsnowcurrently
approved these changes
Oct 3, 2023
|
I've merged the 'main' branch into this PR to resolve merge conflicts. |
|
@colesbury, I'm going to merge this. Please keep an eye on the buildbots. |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ythongh-109915) This adds a new field 'state' to PyThreadState that can take on one of three values: _Py_THREAD_ATTACHED, _Py_THREAD_DETACHED, or _Py_THREAD_GC. The "attached" and "detached" states correspond closely to acquiring and releasing the GIL. The "gc" state is current unused, but will be used to implement stop-the-world GC for --disable-gil builds in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field 'state' to PyThreadState that can take on one of three values:
_Py_THREAD_ATTACHED,_Py_THREAD_DETACHED, or_Py_THREAD_GC. The "attached" and "detached" states correspond closely to closely to acquiring and releasing the GIL. The "gc" state is current unused, but will be used to implement stop-the-world GC for--disable-gilbuilds in the near future.ATTACHED,DETACHED,GCtoPyThreadStateto support PEP 703 #109549