-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112758: Updated pathlib documentation for PurePath.match #112814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this! I think we could be a little more specific, and point towards the os.PathLike
interface - see inline comment.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. Hope everything is good! |
Looks grand, thanks very much! |
Thanks @tpackard1 for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…thonGH-112814) (cherry picked from commit ed8720a) Co-authored-by: Taylor Packard <[email protected]>
GH-112882 is a backport of this pull request to the 3.12 branch. |
Updated the PurePath.match based on issue #112758
Added the following to the pathlib documentation:
Changed in Version 3.12: Accepts another path object.
I am not sure if this wording is correct and/or if this change to the documentation needs backport to 3.12 documentation. If either one or both of these changes need to be made I will make the necessary adjustments.
PurePath.match
accepts aPurePath
pattern only since Python 3.12 #112758📚 Documentation preview 📚: https://cpython-previews--112814.org.readthedocs.build/