Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-112758: Updated pathlib documentation for PurePath.match #112814

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

tpackard1
Copy link
Contributor

@tpackard1 tpackard1 commented Dec 6, 2023

Updated the PurePath.match based on issue #112758

Added the following to the pathlib documentation:
Changed in Version 3.12: Accepts another path object.

I am not sure if this wording is correct and/or if this change to the documentation needs backport to 3.12 documentation. If either one or both of these changes need to be made I will make the necessary adjustments.


📚 Documentation preview 📚: https://cpython-previews--112814.org.readthedocs.build/

@tpackard1 tpackard1 requested a review from barneygale as a code owner December 6, 2023 21:02
Copy link

cpython-cla-bot bot commented Dec 6, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this! I think we could be a little more specific, and point towards the os.PathLike interface - see inline comment.

Doc/library/pathlib.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Dec 8, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tpackard1
Copy link
Contributor Author

I have made the requested changes; please review again. Hope everything is good!

@barneygale
Copy link
Contributor

Looks grand, thanks very much!

@barneygale barneygale merged commit ed8720a into python:main Dec 8, 2023
24 of 25 checks passed
@barneygale barneygale added the needs backport to 3.12 bug and security fixes label Dec 8, 2023
@miss-islington-app
Copy link

Thanks @tpackard1 for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 8, 2023

GH-112882 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 8, 2023
barneygale pushed a commit that referenced this pull request Dec 8, 2023
…H-112814) (#112882)

gh-112758: Updated pathlib documentation for PurePath.match (GH-112814)
(cherry picked from commit ed8720a)

Co-authored-by: Taylor Packard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants