Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-112532: Require mimalloc in --disable-gil builds #112883

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Dec 8, 2023

In --disable-gil builds, the default allocator is now "mimalloc" and the "malloc" and "pymalloc" allocators are disabled.

The --disable-gil builds will rely on mimalloc for finding GC objects as well as for some thread-safety guarantees. That will require building with mimalloc and using it at runtime.

In `--disable-gil` builds, the default allocator is now "mimalloc" and
the "malloc" and "pymalloc" allocators are disabled.
@colesbury colesbury requested a review from DinoV December 8, 2023 21:37
@colesbury colesbury marked this pull request as ready for review December 8, 2023 21:37
configure.ac Show resolved Hide resolved
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Waiting @DinoV

@corona10
Copy link
Member

corona10 commented Dec 12, 2023

I am merging this PR to protect it from conflict with other PRs.
@DinoV Please let me know if there is an issue with this commit.
cc @colesbury @erlend-aasland

@corona10 corona10 merged commit fdee7b7 into python:main Dec 12, 2023
32 checks passed
@colesbury colesbury deleted the disable-gil-mimalloc branch December 12, 2023 16:50
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants