Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112205: Require @getter and @setter to be methods #113278

Merged
merged 6 commits into from
Dec 19, 2023
Merged

gh-112205: Require @getter and @setter to be methods #113278

merged 6 commits into from
Dec 19, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 19, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 19, 2023
Closed
AlexWaygood
AlexWaygood reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- could you add a test? ;)

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland changed the title gh-112205: Require @getter and @setter to be class methods gh-112205: Require @getter and @setter to be methods Dec 19, 2023
AlexWaygood
AlexWaygood approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland erlend-aasland merged commit 6a69b80 into python:main Dec 19, 2023
35 checks passed
@erlend-aasland erlend-aasland deleted the clinic/getset-guard branch December 19, 2023 11:32
@corona10 corona10 mentioned this pull request Dec 19, 2023
Merged
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@erlend-aasland @AlexWaygood @ryan-duve
pythongh-112205: Require @Getter and @Setter to be methods (python#11…
586355d 
…3278)

Co-authored-by: Alex Waygood <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland @AlexWaygood @aisk
pythongh-112205: Require @Getter and @Setter to be methods (python#11…
a1284ea 
…3278)

Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@erlend-aasland @AlexWaygood @Glyphack
pythongh-112205: Require @Getter and @Setter to be methods (python#11…
78f1dc5 
…3278)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @AlexWaygood