Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation in __post_init__ documentation. #114666

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Fix indentation in __post_init__ documentation. #114666

merged 1 commit into from
Jan 28, 2024

Conversation

bhushan-mohanraj
Copy link
Contributor

@bhushan-mohanraj bhushan-mohanraj commented Jan 28, 2024 •
edited by github-actions bot
Loading

A small fix in the Rectangle example in the documentation for __post_init__ in dataclasses.

📚 Documentation preview 📚: https://cpython-previews--114666.org.readthedocs.build/

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jan 28, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 28, 2024
Eclips4
Eclips4 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually valid syntax, but let's keep it consistent (in terms of indents) with other examples.

@ericvsmith ericvsmith merged commit d00fbed into python:main Jan 28, 2024
30 checks passed
@bhushan-mohanraj bhushan-mohanraj deleted the patch-1 branch January 29, 2024 02:29
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@bhushan-mohanraj @aisk
Fix indentation in __post_init__ documentation. (pythongh-114666)
34818b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhushan-mohanraj @Eclips4 @ericvsmith