-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more references to datetime and time classes #114717
Fix more references to datetime and time classes #114717
Conversation
They could be confused with references to datetime and time modules.
@smontanaro, please look at this. |
@serhiy-storchaka The changes to all three files LGTM. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @serhiy-storchaka, I could not cleanly backport this to
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to
|
) They could be confused with references to datetime and time modules. (cherry picked from commit 39c766b) Co-authored-by: Serhiy Storchaka <[email protected]>
@@ -1678,7 +1678,7 @@ Usage of ``KabulTz`` from above:: | |||
:class:`.time` Objects | |||
---------------------- | |||
|
|||
A :class:`time` object represents a (local) time of day, independent of any particular | |||
A :class:`.time` object represents a (local) time of day, independent of any particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think it's worth its own PR to make just this change, but FWIW, I would have just suppressed the link here, i.e.
A :class:`.time` object represents a (local) time of day, independent of any particular | |
A :class:`!time` object represents a (local) time of day, independent of any particular |
The link is not useful, as it only takes the user two lines lower on the same page. It only adds visual clutter to the docs
GH-114725 is a backport of this pull request to the 3.12 branch. |
) They could be confused with references to datetime and time modules. (cherry picked from commit 39c766b) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-114726 is a backport of this pull request to the 3.11 branch. |
…H-114725) They could be confused with references to datetime and time modules. (cherry picked from commit 39c766b) Co-authored-by: Serhiy Storchaka <[email protected]>
They could be confused with references to datetime and time modules.
They could be confused with references to datetime and time modules.
📚 Documentation preview 📚: https://cpython-previews--114717.org.readthedocs.build/