gh-113743: Use per-interpreter locks for types #115541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
force-pushed
the
nogil_type_mro_per_interp
branch
from
00aa303 to
a60b688
Compare
DinoV
requested review from
ericsnowcurrently and
markshannon
as code owners
DinoV
changed the title
colesbury
approved these changes
Feb 16, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Move type-lock to per-interpreter lock to avoid heavy contention in interpreters test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global lock causes heavy contention in
test_interpreters, this moves it to be per-interpreter. This makes_PyStaticType_InitBuiltinnot entirely thread safe anymore, but that can be dealt with later.