Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111968: Split _Py_async_gen_asend_freelist out of _Py_async_gen_fr… #115546

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 16, 2024

@corona10
Copy link
Member Author

➜  cpython git:(gh-111968-async) ✗ ./python.exe -m test test_asyncio -R 3:3
Using random seed: 1394472447
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 4.04 Run 30 tests sequentially
0:00:00 load avg: 4.04 [ 1/30] test_asyncio.test_base_events
beginning 6 repetitions
123456
......
0:00:06 load avg: 3.73 [ 2/30] test_asyncio.test_buffered_proto
beginning 6 repetitions
123456
......
0:00:06 load avg: 3.73 [ 3/30] test_asyncio.test_context
beginning 6 repetitions
123456
......
0:00:08 load avg: 3.73 [ 4/30] test_asyncio.test_eager_task_factory
beginning 6 repetitions
123456
......
0:00:13 load avg: 3.75 [ 5/30] test_asyncio.test_events
beginning 6 repetitions
123456
......
0:01:01 load avg: 4.94 [ 6/30] test_asyncio.test_futures -- test_asyncio.test_events passed in 48.6 sec
beginning 6 repetitions
123456
......
0:01:08 load avg: 5.99 [ 7/30] test_asyncio.test_futures2
beginning 6 repetitions
123456
......
0:01:08 load avg: 5.99 [ 8/30] test_asyncio.test_locks
beginning 6 repetitions
123456
......
0:01:14 load avg: 5.75 [ 9/30] test_asyncio.test_pep492
beginning 6 repetitions
123456
......
0:01:15 load avg: 5.75 [10/30] test_asyncio.test_proactor_events
beginning 6 repetitions
123456
......
0:01:16 load avg: 6.33 [11/30] test_asyncio.test_protocols
beginning 6 repetitions
123456
......
0:01:16 load avg: 6.33 [12/30] test_asyncio.test_queues
beginning 6 repetitions
123456
......
0:01:18 load avg: 6.33 [13/30] test_asyncio.test_runners
beginning 6 repetitions
123456
......
0:01:20 load avg: 6.33 [14/30] test_asyncio.test_selector_events
beginning 6 repetitions
123456
......
0:01:21 load avg: 6.33 [15/30] test_asyncio.test_sendfile
beginning 6 repetitions
123456
......
0:01:27 load avg: 6.20 [16/30] test_asyncio.test_server
beginning 6 repetitions
123456
......
0:01:29 load avg: 6.20 [17/30] test_asyncio.test_sock_lowlevel
beginning 6 repetitions
123456
......
0:01:41 load avg: 6.37 [18/30] test_asyncio.test_ssl
beginning 6 repetitions
123456
......
0:02:21 load avg: 4.16 [19/30] test_asyncio.test_sslproto -- test_asyncio.test_ssl passed in 39.9 sec
beginning 6 repetitions
123456
......
0:02:47 load avg: 3.93 [20/30] test_asyncio.test_streams
beginning 6 repetitions
123456
......
0:02:52 load avg: 3.77 [21/30] test_asyncio.test_subprocess
beginning 6 repetitions
123456
......
0:03:43 load avg: 2.54 [22/30] test_asyncio.test_taskgroups -- test_asyncio.test_subprocess passed in 50.5 sec
beginning 6 repetitions
123456
......
0:04:22 load avg: 2.30 [23/30] test_asyncio.test_tasks -- test_asyncio.test_taskgroups passed in 38.7 sec
beginning 6 repetitions
123456
......
0:06:08 load avg: 2.63 [24/30] test_asyncio.test_threads -- test_asyncio.test_tasks passed in 1 min 46 sec
beginning 6 repetitions
123456
......
0:06:09 load avg: 2.63 [25/30] test_asyncio.test_timeouts
beginning 6 repetitions
123456
......
0:06:12 load avg: 2.66 [26/30] test_asyncio.test_transports
beginning 6 repetitions
123456
......
0:06:12 load avg: 2.66 [27/30] test_asyncio.test_unix_events
beginning 6 repetitions
123456
......
0:06:15 load avg: 2.66 [28/30] test_asyncio.test_waitfor
beginning 6 repetitions
123456
......
0:06:22 load avg: 2.69 [29/30] test_asyncio.test_windows_events
test_asyncio.test_windows_events skipped -- Windows only
0:06:22 load avg: 2.69 [30/30] test_asyncio.test_windows_utils -- test_asyncio.test_windows_events skipped
test_asyncio.test_windows_utils skipped -- Windows only
test_asyncio.test_windows_utils skipped

== Tests result: SUCCESS ==

2 tests skipped:
    test_asyncio.test_windows_events test_asyncio.test_windows_utils

28 tests OK.

Total duration: 6 min 22 sec
Total tests: run=2,493 skipped=56
Total test files: run=30/30 skipped=2
Result: SUCCESS

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for taking care of this and paying such close attention to the details. I had missed that there were two freelists in this one struct. Nice catch!

@corona10 corona10 merged commit 8db8d71 into python:main Feb 17, 2024
35 checks passed
@corona10 corona10 deleted the gh-111968-async branch February 17, 2024 01:03
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants