-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116515: Clear thread-local state before tstate_delete_common() #116517
Conversation
This moves current_fast_clear() up so that the current thread state is NULL while running tstate_delete_common().
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 4f541ef 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGM
I could swear that didn't work before! 😄 I'm guessing a few things have shifted around with the no-gil work that sorted out the other inconsistencies. Thanks for taking care of this.
(I'm assuming CI doesn't spoil the mood by disproving this fix.)
!buildbot debian root |
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 4f541ef 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
…() (python#116517) This moves `current_fast_clear()` up so that the current thread state is `NULL` while running `tstate_delete_common()`. This doesn't fix any bugs, but it means that we are more consistent that `_PyThreadState_GET() != NULL` means that the thread is "attached".
…() (python#116517) This moves `current_fast_clear()` up so that the current thread state is `NULL` while running `tstate_delete_common()`. This doesn't fix any bugs, but it means that we are more consistent that `_PyThreadState_GET() != NULL` means that the thread is "attached".
This moves
current_fast_clear()
up so that the current thread state isNULL
while runningtstate_delete_common()
.This doesn't fix any bugs, but it means that we are more consistent that
_PyThreadState_GET() != NULL
means that the thread is "attached".