Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90190: Add doc for using singledispatch with precise collection type hints #116544

Merged
merged 8 commits into from
Sep 27, 2024
Merged

gh-90190: Add doc for using singledispatch with precise collection type hints #116544

merged 8 commits into from
Sep 27, 2024

Conversation

Delengowski
Copy link
Contributor

@Delengowski Delengowski commented Mar 9, 2024 •
edited by github-actions bot
Loading

@Delengowski Delengowski requested a review from rhettinger as a code owner March 9, 2024 14:26
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Mar 9, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Mar 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 9, 2024
Closed
@AlexWaygood AlexWaygood self-requested a review March 9, 2024 14:37
@rhettinger rhettinger removed their request for review March 9, 2024 18:25
savannahostrowski
savannahostrowski previously requested changes May 9, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think that this looks good. I had a couple of small comments/nits.

@Delengowski
Copy link
Contributor Author

@savannahostrowski thank you for the review. I believe I resolved all comments.

@AlexWaygood Would you be able to look at this when you get a chance? You originally told me to add you when I mentioned a desire to do this in the linked issue.

@AlexWaygood
Copy link
Member

Sorry, this dropped off my radar; will try to take a look soon!

@AlexWaygood AlexWaygood added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 27, 2024
@savannahostrowski
Copy link
Member

@AlexWaygood I was going through PRs and noticed that this may have slipped through the cracks. Thoughts?

AlexWaygood
AlexWaygood approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and thanks @savannahostrowski for the ping! Sorry for the delay here, this is great

@AlexWaygood AlexWaygood dismissed savannahostrowski’s stale review September 27, 2024 20:50

comments were addressed

@AlexWaygood AlexWaygood changed the title gh-90190: Adds doc for singledispatch with GenericAlias annotation gh-90190: Add doc for using singledispatch with precise collection type hints Sep 27, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) September 27, 2024 20:51
@AlexWaygood AlexWaygood merged commit 2357d5b into python:main Sep 27, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @Delengowski for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski @miss-islington
pythongh-90190: Add doc for using singledispatch with precise colle…
0864743 
…ction type hints (pythonGH-116544)

(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124710 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski @miss-islington
pythongh-90190: Add doc for using singledispatch with precise colle…
ea2ca32 
…ction type hints (pythonGH-116544)

(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124711 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 27, 2024
AlexWaygood pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @Delengowski
[3.12] gh-90190: Add doc for using singledispatch with precise coll…
a178445 
…ection type hints (GH-116544) (#124711)

Co-authored-by: Matt Delengowski <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @Delengowski
[3.13] gh-90190: Add doc for using singledispatch with precise coll…
2b74cce 
…ection type hints (GH-116544) (#124710)

gh-90190: Add doc for using `singledispatch` with precise collection type hints (GH-116544)
(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@savannahostrowski savannahostrowski savannahostrowski left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Delengowski @AlexWaygood @savannahostrowski