gh-116764: Fix regressions in urllib.parse.parse_qsl() #116801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore support of None and other false values (fix regression introduced in pythongh-74668). * Raise TypeError for non-zero integers and non-empty sequences.
serhiy-storchaka
added
needs backport to 3.11
msullivan
reviewed
Mar 15, 2024
| qs = bytes(qs) | ||
| if not qs: | ||
| return [] | ||
| qs = bytes(memoryview(qs)) |
There was a problem hiding this comment.
Is it worth having a comment why going through memoryview first is needed (to disallow stuff like bytes(10)?), or is that trick idiomatic in standard library code?
There was a problem hiding this comment.
No, it is not so common. Added a comment.
serhiy-storchaka
changed the title
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 16, 2024
…H-116801) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in pythongh-74668 (bdba8ef). (cherry picked from commit 1069a46) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-116894 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 16, 2024
…H-116801) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in pythongh-74668 (bdba8ef). (cherry picked from commit 1069a46) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-116895 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 16, 2024
) (GH-116894) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in gh-74668 (bdba8ef). (cherry picked from commit 1069a46) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 16, 2024
) (GH-116895) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in gh-74668 (bdba8ef). (cherry picked from commit 1069a46) Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…H-116801) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in pythongh-74668 (bdba8ef).
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…H-116801) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in pythongh-74668 (bdba8ef).
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…H-116801) * Restore support of None and other false values. * Raise TypeError for non-zero integers and non-empty sequences. The regressions were introduced in pythongh-74668 (bdba8ef).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib.parse.parse_qsl(None)behavior #116764