Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-112536: Add support for thread sanitizer (TSAN) (gh-112648) #116926

Closed
wants to merge 3 commits into from
Closed

[3.11] gh-112536: Add support for thread sanitizer (TSAN) (gh-112648) #116926

wants to merge 3 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 17, 2024 •
edited by bedevere-app bot
Loading

(cherry picked from commit 88cb972)

Co-authored-by: Samet YASLAN [email protected]

This was referenced Mar 17, 2024
Merged
Closed
@pitrou
Copy link
Member Author

pitrou commented Mar 17, 2024

I checked that this builds successfully locally, and that a couple of tests pass (test_thread, test_io, test_importlib, test_threadsignals, test_syslog, test_threading_local).

corona10
corona10 approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's just wait if there are major objections or not :)
And by the way, thanks for the all suggestions (to care about the GIL build and backporting!)

@pitrou pitrou requested a review from pablogsal March 17, 2024 16:01
@pitrou
Copy link
Member Author

pitrou commented Mar 17, 2024

Okay, I'm not sure if it makes sense to backport this to 3.11, since the final bugfix release is scheduled for 2024-04-01, i.e. very soon. Perhaps we should just not bother.

@pitrou
Copy link
Member Author

pitrou commented Mar 19, 2024

I'm closing for now.

@pitrou pitrou closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @corona10 @samety