gh-113317: Argument Clinic: Add libclinic.clanguage #117455
Conversation
vstinner
force-pushed
the
ac_clang
branch
2 times, most recently
from
21917ec to
04d91d6
Compare
|
@erlend-aasland: I updated the PR to address your review. Please review the updated PR. I used git rebase to rewrite the commit message and rename files. |
There was a problem hiding this comment.
Thanks! I think libclinic.codegen makes sense. Also, it makes sense to put the option group stuff together with the parameter stuff (currently in function.py).
I realise that we already got a libclinic.language.py file with the PythonLanguage and Language classes. I'm fine with using clanguage.py instead of lang_c.py, as was your original suggestion. Up to you.
Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
I renamed the file to |
) Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
Add libclinic.lang_c module and move the following classes and functions there:
Add libclinic.codegen and move the following classes there:
Move these functions to libclinic.function: