Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer guide link to README.rst #118

Closed
wants to merge 3 commits into from
Closed

Add developer guide link to README.rst #118

wants to merge 3 commits into from

Conversation

ncoghlan
Copy link
Contributor

No description provided.

This was referenced Feb 15, 2017
Closed
Closed
Mariatta
Mariatta approved these changes Feb 15, 2017
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM. Thanks, @ncoghlan :)

@Mariatta
Copy link
Member

Does this need backported?

@zware
Copy link
Member

zware commented Feb 15, 2017

The devguide is also linked in the Documentation section below; should it be removed from there since it's added at the top?

vstinner
vstinner requested changes Feb 15, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the now redundant link to the devguide in the Documentation section.

@vstinner vstinner added the docs Documentation in the Doc dir label Feb 15, 2017
@ncoghlan
Copy link
Contributor Author

The online conflict resolution failed miserably, so I'll just close this and make a new PR

@ncoghlan ncoghlan closed this Feb 18, 2017
@ncoghlan
Copy link
Contributor Author

Replacement PR: #145

@berkerpeksag berkerpeksag deleted the ncoghlan-devguide-link branch February 18, 2017 21:44
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

@auvipy auvipy auvipy approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ncoghlan @Mariatta @zware @vstinner @auvipy @the-knights-who-say-ni