Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: TSAN fix race on gstate->young.count #118313

Merged
merged 16 commits into from
Apr 29, 2024
Merged

gh-117657: TSAN fix race on gstate->young.count #118313

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e7a4477
TSAN fix race between atomic and none-atomic mutation of tate->young.…
SonicField Apr 26, 2024
14858c2
Merge remote-tracking branch 'upstream/main'
SonicField Apr 26, 2024
5457972
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 26, 2024
d83833c
merge with upstream
SonicField Apr 26, 2024
edd9b7b
TSAN: move gc counter reset into critical section
SonicField Apr 26, 2024
e9bae12
Resolved merge conflict in Tools/tsan/suppressions_free_threading.txt
SonicField Apr 26, 2024
e1e040c
Merge branch 'main' of github.com:SonicField/cpython
SonicField Apr 26, 2024
dc97546
Merge branch 'main' of github.com:SonicField/cpython
SonicField Apr 26, 2024
2f200c9
Merge branch 'main' of github.com:SonicField/cpython
SonicField Apr 26, 2024
364d1d9
TSAN: Fix compiler warning in gc patch
SonicField Apr 26, 2024
6ec56ac
Merge branch 'main' into main
SonicField Apr 29, 2024
ef64718
Merge branch 'main' into main
SonicField Apr 29, 2024
822f8cc
Merge branch 'main' into main
SonicField Apr 29, 2024
655e071
Remove not require news entry
SonicField Apr 29, 2024
85b7b5c
Merge branch 'main' of github.com:SonicField/cpython
SonicField Apr 29, 2024
29c2696
Merge branch 'main' into main
SonicField Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-04-26-12-08-33.gh-issue-117657.D6Zd73.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Continuing to whack-a-mole TSAN issues found in No-GIL tests.
SonicField marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion Python/gc_free_threading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,8 @@ gc_collect_main(PyThreadState *tstate, int generation, _PyGC_Reason reason)
if (generation+1 < NUM_GENERATIONS) {
gcstate->old[generation].count += 1;
}
gcstate->young.count = 0;

_Py_atomic_store_int(&gcstate->young.count, 0);
colesbury marked this conversation as resolved.
Show resolved Hide resolved
for (i = 1; i <= generation; i++) {
gcstate->old[i-1].count = 0;
}
Expand Down
1 change: 0 additions & 1 deletion Tools/tsan/suppressions_free_threading.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ race:_PyObject_GC_TRACK
race:_PyParkingLot_Park
race:_PyType_HasFeature
race:assign_version_tag
race:gc_collect_main
race:gc_restore_tid
race:initialize_new_array
race:insertdict
Expand Down
Loading