-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119946: Allow Enum to work with ABC mixin #119947
base: main
Are you sure you want to change the base?
Conversation
ygale
commented
Jun 2, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Cannot define Enum class with a mixin class derived from ABC #119946
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
4d0d1d8
to
2563fa2
Compare
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
8f255ce
to
a141a73
Compare
Could you avoid force pushing please?
|
a141a73
to
8487a73
Compare
Misc/NEWS.d/next/Library/2024-06-02-19-26-01.gh-issue-119946.g8wtLh.rst
Outdated
Show resolved
Hide resolved
…8wtLh.rst Co-authored-by: Nice Zombies <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test where a new enum class is created without the color
method to ensure that enum creation fails.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |