Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119946: Allow Enum to work with ABC mixin #119947

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ygale
Copy link

@ygale ygale commented Jun 2, 2024

@ygale ygale requested a review from ethanfurman as a code owner June 2, 2024 15:40
Copy link

cpython-cla-bot bot commented Jun 2, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ygale ygale force-pushed the fix-issue-119946-enum-with-abc branch 2 times, most recently from 8f255ce to a141a73 Compare June 2, 2024 16:31
@nineteendo
Copy link
Contributor

Could you avoid force pushing please?

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits.

Lib/test/test_enum.py Outdated Show resolved Hide resolved
@ygale ygale force-pushed the fix-issue-119946-enum-with-abc branch from a141a73 to 8487a73 Compare June 2, 2024 17:17
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test where a new enum class is created without the color method to ensure that enum creation fails.

@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants