gh-120176: Reduce number of compares in index range checks #120181
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #9784 (discussed in #72583 and #67741) and extracts the helper function into
internal/pycore_abstract.h
and uses it where applicable to reduce the number of comparisons in index range checks.See https://godbolt.org/z/jM8oexT1d for an assembly comparison.
I feel like this change doesn't reduce readability but let me know if such micro optimisation does not justify the code churn.