Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Add TSAN suppression for set_default_allocator_unlocked #120500

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

aisk
Copy link
Member

@aisk aisk commented Jun 14, 2024

I'm using macOS 14.2 with x86_64 CPU, this race conflict always occurs on my local machine.

Clang version:

clang -v
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a few socket races as well that pop up. We should add them to the suppressions.

@aisk
Copy link
Member Author

aisk commented Jun 14, 2024

I think we can enable the TSAN free-threads builds tests on macOS?

@aisk
Copy link
Member Author

aisk commented Jun 14, 2024

Tried to enable TSAN check on macOS #120502, but it will hang forever for the test_capi.test_mem test, and the set_default_allocator_unlocked race didn't get triggered...

https://github.com/python/cpython/actions/runs/9517250225/job/26235426291?pr=120502


Updated:

Sorry, my bad, the set_default_allocator_unlocked race did get triggered, but the races on socket didn't triggered. So I think we can continue with this change, and I will find a way to resolve the hang in another PR.

@Fidget-Spinner Fidget-Spinner merged commit 2bacc23 into python:main Jun 14, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2024
…ked (pythonGH-120500)

Add TSAN suppression for set_default_allocator_unlocked
(cherry picked from commit 2bacc23)

Co-authored-by: AN Long <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 14, 2024

GH-120510 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 14, 2024
Fidget-Spinner pushed a commit that referenced this pull request Jun 14, 2024
…cked (GH-120500) (#120510)

gh-117657: Add TSAN suppression for set_default_allocator_unlocked (GH-120500)

Add TSAN suppression for set_default_allocator_unlocked
(cherry picked from commit 2bacc23)

Co-authored-by: AN Long <[email protected]>
@aisk aisk deleted the update-tsan-suppression branch June 14, 2024 16:48
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants