Fix cache restoration for Hypothesis CI job #121756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the CI workflow job running Hypothesis was mistakenly set
up to use a cache restoration key prefixed with a leading
hyphen [[1]]. This was done in an attempt to figure out the right
format for the `actions/cache` input argument called `restore-keys`
as the official examples tend to be confusing [[2]].
This results no cache being found for the Hypothesis database on
lookup [[3]] and the logs contain the following:
Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-
The patch corrects that by dropping the unintended characters from the
catch-all cache key.
[1]: python@ccbb010#r1677102123
[2]: actions/cache#1173
[3]: https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24
hugovk
added
skip issue
skip news
needs backport to 3.12
|
Here's the proof from this PR's CI run that cache restoration works now, with the patch applied: Cache Size: ~0 MB (22203 B)
/usr/bin/tar -xf /home/runner/work/_temp/49dc92bc-12d7-4daa-afbd-fb3faf161361/cache.tzst -P -C /home/runner/work/cpython/cpython --use-compress-program unzstd
Cache restored successfully
Cache restored from key: hypothesis-database-9927179210(https://github.com/python/cpython/actions/runs/9927318541/job/27422127017?pr=121756#step:21:27) |
hugovk
changed the title
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2024
(cherry picked from commit 6505bda) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
GH-121759 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2024
(cherry picked from commit 6505bda) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
GH-121760 is a backport of this pull request to the 3.12 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jul 14, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Jul 14, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the CI workflow job running Hypothesis was mistakenly set up to use a cache restoration key prefixed with a leading hyphen [1]. This was done in an attempt to figure out the right format for the
actions/cacheinput argument calledrestore-keysas the official examples tend to be confusing [2].This results no cache being found for the Hypothesis database on lookup [3] and the logs contain the following:
The patch corrects that by dropping the unintended characters from the catch-all cache key.