Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "gh-121946: Temporarily switch to llvm-17 in TSan CI (#121975)" #122032

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Revert "gh-121946: Temporarily switch to llvm-17 in TSan CI (#121975)" #122032

merged 2 commits into from
Jul 22, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jul 19, 2024 •
edited by bedevere-app bot
Loading

This reverts commit 12c1afa.

The LLVM 18 Ubuntu package is working now.

@colesbury
Revert "pythongh-121946: Temporarily switch to llvm-17 in TSan CI (py…
6bf269e 
…thon#121975)"

This reverts commit 12c1afa.

The LLVM 18 Ubuntu package is working now.
@colesbury colesbury added skip news needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2024
Open
@colesbury
Copy link
Contributor Author

colesbury commented Jul 19, 2024 •
edited
Loading

EDIT: Looks like it's fixed now as of July 22, 2024.

Looks like I was too optimistic, but I guess this PR will be ready for when the Ubuntu package is actually fixed.

@colesbury colesbury marked this pull request as ready for review July 22, 2024 16:22
@colesbury colesbury merged commit ad935a9 into python:main Jul 22, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-121946-revert branch July 22, 2024 17:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
@colesbury @miss-islington
Revert "pythongh-121946: Temporarily switch to llvm-17 in TSan CI (py…
c9fefb5 
…thonGH-121975)" (pythonGH-122032)

This reverts commit 12c1afa.

The LLVM 18 Ubuntu package is working now.
(cherry picked from commit ad935a9)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 22, 2024

GH-122131 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2024
colesbury added a commit that referenced this pull request Jul 22, 2024
@miss-islington @colesbury
[3.13] Revert "gh-121946: Temporarily switch to llvm-17 in TSan CI (G…
e175bd3 
…H-121975)" (GH-122032) (#122131)

This reverts commit 53774e9.

The LLVM 18 Ubuntu package is working now.
(cherry picked from commit ad935a9)

Co-authored-by: Sam Gross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @Fidget-Spinner