gh-122191: Fix test_warnings failure if run with -Werror #122222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__spec__.loader is now required in the module globals (see pythongh-86298).
serhiy-storchaka
added
tests
AlexWaygood
reviewed
Jul 24, 2024
AlexWaygood
reviewed
Jul 24, 2024
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Jul 24, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 25, 2024
…nGH-122222) __spec__.loader is now required in the module globals (see pythongh-86298). (cherry picked from commit 9b4fe9b) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Thank you for your review @AlexWaygood. |
|
GH-122256 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jul 25, 2024
…pythonGH-122222) __spec__.loader is now required in the module globals (see pythongh-86298). (cherry picked from commit 9b4fe9b) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-122257 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 25, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 25, 2024
…22222) (GH-122256) __spec__.loader is now required in the module globals (see gh-86298). (cherry picked from commit 9b4fe9b) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__spec__.loaderis now required in the module globals (see gh-86298).test_warningsfails if run with-Werror#122191