GH-118093: Add tier two support for LOAD_ATTR_PROPERTY
#122283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a lot like GH-122253, in that it's mostly done for completeness so that we can stay in tier two across a
LOAD_ATTR_PROPERTY
. No real impact on stats or perf, beyond the obvious.This is a minor change for the instruction itself, though: the current instruction can't be split up, since it needs two cache entries (a function and a version for that function) to be active at the same time. This replaces the exact function version check with looser checks on all of the members of the code object that we care about.