GH-73991: Rework pathlib.Path.rmtree() into delete()
#122368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcoming `move()` and `copy()` methods (which will also accept any type of file.)
AA-Turner
reviewed
Jul 27, 2024
AA-Turner
reviewed
Jul 29, 2024
|
@nineteendo I'd welcome your review on this, if you have the time and inclination. No worries if not! Thanks in advance :) |
nineteendo
reviewed
Jul 30, 2024
We generally put the more primitive functions first.
|
Thank you very much for the reviews :) |
|
Sorry for my tardiness! Do let me know if there's anything else I can usefully review A |
|
Not tardy at all I don't think! :]
Since you're offering, the next PR on the critical path here is #122369. But there's a lot going on there, so feel free to give it a miss or ask me to explain it further / break it up / whatever. Thanks again! And feel free to assign me when you next need a review of something. |
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…n#122368) Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcoming `move()` and `copy()` methods (which will also accept any type of file.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
pathlib.Path.rmtree()todelete(), and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcomingmove()andcopy()methods (which will also accept any type of file.)📚 Documentation preview 📚: https://cpython-previews--122368.org.readthedocs.build/