gh-94512: Fix forced arg format in AC-processed posixmodule.c
#122516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
picnixz
commented
Jul 31, 2024
•
picnixz
commented
- Issue: Fix forced arg format in AC-processed modules with custom converters #94512
picnixz
changed the title
posixmodule.c
7 tasks
erlend-aasland
approved these changes
Oct 24, 2024
| ival = PyLong_AsSsize_t(iobj); | ||
| Py_DECREF(iobj); | ||
| } | ||
| if (ival == -1 && PyErr_Occurred()) { |
There was a problem hiding this comment.
We should teach Argument Clinic to generate this as:
if (ival == (Py_ssize_t)-1 && PyErr_Occurred()) {There was a problem hiding this comment.
I can work on a fix tomorrow if you want?
|
Thanks, Bénédikt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.