gh-123110: correct note about _Bool in the struct module docs #123111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
added
needs backport to 3.12
|
I think we require C99 since Python 3.6, right? |
|
Only partially. I would guess even with 3.5, since python/peps@b6efe6e. What's important: booleans are required for 3.8+. I'm not sure if this is important to backport, but (technically) we can. |
|
It's fine, I just wanted to be sure that I could mark it as backportable up to 3.12 without worries. |
|
BTW, I'm not sure if it does make sense to have both n*_bool() and b*_bool() functions. First set should handle different endianness. |
skirpichev
commented
Aug 18, 2024
skirpichev
commented
Aug 18, 2024
serhiy-storchaka
approved these changes
Aug 18, 2024
|
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 18, 2024
…ythonGH-123111) (cherry picked from commit b0f462d) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-123126 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 18, 2024
…ythonGH-123111) (cherry picked from commit b0f462d) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-123127 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Aug 19, 2024
kumaraditya303
pushed a commit
that referenced
this pull request
Aug 19, 2024
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--123111.org.readthedocs.build/