gh-123811: test that round() can return signed zero #123829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skirpichev
commented
Sep 8, 2024
•
skirpichev
commented
- Issue: Issue with Round Function in Python #123811
This comment was marked as resolved.
This comment was marked as resolved.
Eclips4
approved these changes
Sep 10, 2024
Eclips4
added
needs backport to 3.12
|
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2024
…23829) (cherry picked from commit d2b9b6f) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-123938 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2024
…23829) (cherry picked from commit d2b9b6f) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-123939 is a backport of this pull request to the 3.12 branch. |
|
Merged, thanks @skirpichev. |
vstinner
added a commit
that referenced
this pull request
Sep 11, 2024
#123939) gh-123811: test that round() can return signed zero (GH-123829) (cherry picked from commit d2b9b6f) Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
Is this tested for Decimal? |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.