-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "gh-123974: Fix time.get_clock_info() on NetBSD (#123975)" #124115
Merged
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:revert-gh-123974
Sep 18, 2024
Merged
Revert "gh-123974: Fix time.get_clock_info() on NetBSD (#123975)" #124115
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:revert-gh-123974
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a revert alone, can we do a PR which does a revert + disable the clock on NetBSD? |
Oh, you did it in #124116 in fact. |
It is better to separate these changes to make backporting to 3.13 easier. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2024
…H-123975)" (pythonGH-124115) This reverts commit b1d6f8a. (cherry picked from commit 79a7410) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-124200 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 18, 2024
)" (GH-124115) (GH-124200) This reverts commit b1d6f8a. (cherry picked from commit 79a7410) Co-authored-by: Serhiy Storchaka <[email protected]>
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
…123975)" (pythonGH-124115) This reverts commit b1d6f8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b1d6f8a.
We should remove
time.thread_time()
on NetBSD instead.