gh-127553: Remove TODO comment in _pydatetime._isoweek1monday
#127564
Conversation
Lib/_pydatetime.py
Outdated
| # If the first weekday is after Thursday, | ||
| # ISO week 1 doesn't start until the next Monday |
There was a problem hiding this comment.
This comment should be moved inside the if and I would only keep "ISO week 1 does not start until the next Monday" (or maybe no comment at all). Waiting for Erlend's opinion on this.
There was a problem hiding this comment.
I'm not sure the comment is needed. The code below speaks for itself, IMO. Let's just remove the XXX comment. After all, that is what the PR title says this PR should do.
There was a problem hiding this comment.
@erlend-aasland Got it! I've reverted the change
picnixz
changed the title
TODO comment in _pydatetime._isoweek1mondayTODO comment in _pydatetime._isoweek1monday
picnixz
added
needs backport to 3.12
|
I think it's better to backport that change so that users don't think we want to improve the implementation. |
This reverts commit 604f61a.
|
Thanks @bombs-kim for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…H-127564) (cherry picked from commit e8b6b39) Co-authored-by: Beomsoo Kim <[email protected]>
|
GH-128500 is a backport of this pull request to the 3.13 branch. |
…H-127564) (cherry picked from commit e8b6b39) Co-authored-by: Beomsoo Kim <[email protected]>
|
GH-128501 is a backport of this pull request to the 3.12 branch. |
) (#128501) (cherry picked from commit e8b6b39) Co-authored-by: Beomsoo Kim <[email protected]>
) (#128500) (cherry picked from commit e8b6b39) Co-authored-by: Beomsoo Kim <[email protected]>
TODOcomment in_pydatetime._isoweek1monday#127553 a optimization has been tried, but it seems that the existing code is nearly optimalTODOcomment in_pydatetime._isoweek1monday#127553