bpo-37689: add Path.is_relative_to() method #14982

shihai1991 · 2019-07-27T17:56:45Z

https://bugs.python.org/issue37689

Doc/library/pathlib.rst

aeros

@shihai1991 Thanks for the contribution! I definitely think that this function would be quite helpful.

I did some testing in the interpreter after installing python through your branch:

OS: Arch Linux 5.2.3

Looks good to me! I just had a few minor suggestions:

Doc/library/pathlib.rst

Misc/NEWS.d/next/Library/2019-07-27-18-00-43.bpo-37689.glEmZi.rst

Doc/library/pathlib.rst

shihai1991 · 2019-07-28T09:34:42Z

@pitrou Hi, Antoine. pls review this PR, if you have free time, thanks :)

aeros · 2019-07-28T15:08:33Z

@shihai1991 Btw, after you've made any changes based on suggestions you can use "Resolve conversation" to show that each one has been addressed (or directly commit the suggestion to the PR). Thanks for making the recommended changes (:

pitrou

Thanks for doing this. Please find some comments below.

Doc/library/pathlib.rst

pitrou · 2019-07-28T15:58:11Z

Doc/library/pathlib.rst

@@ -539,6 +539,20 @@ Pure paths provide the following methods and properties:
      ValueError: '/etc/passwd' does not start with '/usr'


+.. method:: PurePath.is_relative_to(*other)
+
+   Return the boolean result that this path is relative to *other* path.


How about Return whether this path is relative to the *other* path?

I agree, this would be an improvement over my earlier suggestion. Since it's modifying a verb, "Return" in this case, I think it might be slightly more correct to explicitly specify the "or not":

Return whether or not this path is relative to the *other* path.

ops， i am not a native english speaker, so i have no idea about "whether(or not)" :(

@shihai1991 That's okay, the distinction is often a pain, even for those of us who are native speakers (:

Lib/test/test_pathlib.py

bedevere-bot · 2019-07-28T16:00:42Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

shihai1991 · 2019-07-29T04:33:01Z

@shihai1991 Btw, after you've made any changes based on suggestions you can use "Resolve conversation" to show that each one has been addressed (or directly commit the suggestion to the PR). Thanks for making the recommended changes (:

np, looks I need change my habit(because i am a gerrit user before:)

shihai1991 · 2019-07-31T15:47:16Z

I have made the requested changes; please review again

bedevere-bot · 2019-07-31T15:47:19Z

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

CuriousLearner

Overall, this looks good to me. I just have a minor suggestion on renaming the parameter as mentioned inline.

Doc/library/pathlib.rst

Lib/pathlib.py

CuriousLearner

Since other methods already have other parameter, I think we're good to go on this.

LGTM 🌮

pitrou

Thanks for the update! Just one additional comment and I think we're good to go.

Doc/library/pathlib.rst

bedevere-bot · 2019-08-12T17:44:32Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

shihai1991 · 2019-08-13T14:51:47Z

I have made the requested changes; please review again

bedevere-bot · 2019-08-13T14:51:51Z

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

pitrou · 2019-08-13T19:54:12Z

Thank you @shihai1991 !

add a is_realative_to function in pathlib module

5cb33c5

the-knights-who-say-ni added the CLA signed label Jul 27, 2019

bedevere-bot added the awaiting review label Jul 27, 2019

📜🤖 Added by blurb_it.

d5c4f8e

tirkarthi reviewed Jul 27, 2019

View reviewed changes

Doc/library/pathlib.rst Outdated Show resolved Hide resolved

aeros approved these changes Jul 28, 2019

View reviewed changes

Doc/library/pathlib.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2019-07-27-18-00-43.bpo-37689.glEmZi.rst Outdated Show resolved Hide resolved

Doc/library/pathlib.rst Outdated Show resolved Hide resolved

Doc/library/pathlib.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Jul 28, 2019

update descr of is_relative_to()

9265704

aeros approved these changes Jul 28, 2019

View reviewed changes

pitrou changed the title ~~bpo-37689: add a is_realative_to function in pathlib module~~ bpo-37689: add Path.is_relative_to() method Jul 28, 2019

pitrou requested changes Jul 28, 2019

View reviewed changes

bedevere-bot removed the awaiting core review label Jul 28, 2019

bedevere-bot added the awaiting changes label Jul 28, 2019

update test cases and desc

62eac3a

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 31, 2019

CuriousLearner reviewed Aug 10, 2019

View reviewed changes

Doc/library/pathlib.rst Show resolved Hide resolved

Lib/pathlib.py Show resolved Hide resolved

CuriousLearner approved these changes Aug 11, 2019

View reviewed changes

pitrou requested changes Aug 12, 2019

View reviewed changes

Doc/library/pathlib.rst Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting change review label Aug 12, 2019

bedevere-bot added the awaiting changes label Aug 12, 2019

update docs

3a42052

bedevere-bot added awaiting change review and removed awaiting changes labels Aug 13, 2019

CuriousLearner approved these changes Aug 13, 2019

View reviewed changes

import PurePath in testsetup

9939817

pitrou approved these changes Aug 13, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Aug 13, 2019

pitrou merged commit 82642a0 into python:master Aug 13, 2019

bedevere-bot removed the awaiting merge label Aug 13, 2019

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-37689: add Path.is_relative_to() method (pythonGH-14982)

c53df41

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-37689: add Path.is_relative_to() method (pythonGH-14982)

555c05c

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-37689: add Path.is_relative_to() method (pythonGH-14982)

939627d

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 27, 2023

bpo-37689: add Path.is_relative_to() method (pythonGH-14982)

9db71d9

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Jul 19, 2024

bpo-37689: add Path.is_relative_to() method (pythonGH-14982)

b9f909d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-37689: add Path.is_relative_to() method #14982

bpo-37689: add Path.is_relative_to() method #14982

shihai1991 commented Jul 27, 2019 •

edited by bedevere-bot

Loading

aeros left a comment

shihai1991 commented Jul 28, 2019

aeros commented Jul 28, 2019

pitrou left a comment

pitrou Jul 28, 2019

aeros Jul 28, 2019

shihai1991 Jul 29, 2019

aeros Jul 29, 2019

bedevere-bot commented Jul 28, 2019

shihai1991 commented Jul 29, 2019

shihai1991 commented Jul 31, 2019

bedevere-bot commented Jul 31, 2019

CuriousLearner left a comment

CuriousLearner left a comment

pitrou left a comment

bedevere-bot commented Aug 12, 2019

shihai1991 commented Aug 13, 2019

bedevere-bot commented Aug 13, 2019

pitrou commented Aug 13, 2019

bpo-37689: add Path.is_relative_to() method #14982

bpo-37689: add Path.is_relative_to() method #14982

Conversation

shihai1991 commented Jul 27, 2019 • edited by bedevere-bot Loading

aeros left a comment

Choose a reason for hiding this comment

shihai1991 commented Jul 28, 2019

aeros commented Jul 28, 2019

pitrou left a comment

Choose a reason for hiding this comment

pitrou Jul 28, 2019

Choose a reason for hiding this comment

aeros Jul 28, 2019

Choose a reason for hiding this comment

shihai1991 Jul 29, 2019

Choose a reason for hiding this comment

aeros Jul 29, 2019

Choose a reason for hiding this comment

bedevere-bot commented Jul 28, 2019

shihai1991 commented Jul 29, 2019

shihai1991 commented Jul 31, 2019

bedevere-bot commented Jul 31, 2019

CuriousLearner left a comment

Choose a reason for hiding this comment

CuriousLearner left a comment

Choose a reason for hiding this comment

pitrou left a comment

Choose a reason for hiding this comment

bedevere-bot commented Aug 12, 2019

shihai1991 commented Aug 13, 2019

bedevere-bot commented Aug 13, 2019

pitrou commented Aug 13, 2019

shihai1991 commented Jul 27, 2019 •

edited by bedevere-bot

Loading