Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38169: Increase code coverage for SharedMemory and ShareableList #16139

Merged
merged 1 commit into from
Jul 19, 2020
Merged

bpo-38169: Increase code coverage for SharedMemory and ShareableList #16139

merged 1 commit into from
Jul 19, 2020

Conversation

vinay0410
Copy link
Contributor

@vinay0410 vinay0410 commented Sep 14, 2019 •
edited by bedevere-bot
Loading

Increase Code Coverage, and add check in SharedMemory when user wants to create shm with size 0, to throw ValueError.

https://bugs.python.org/issue38169

@vinay0410 vinay0410 requested a review from tiran as a code owner September 14, 2019 07:54
@vinay0410 vinay0410 force-pushed the fix-issue-38169 branch 3 times, most recently from 2ae487a to 0e2c856 Compare September 14, 2019 12:14
@vinay0410
Copy link
Contributor Author

Hi @applio , Could you please review this ?

@vinay0410
Copy link
Contributor Author

Hi @applio , Could you please review this.

@vinay0410
Copy link
Contributor Author

HI, @applio , Can you please review this ?

@vinay0410
Copy link
Contributor Author

@tiran , Could you please review this ?

@vinay0410 vinay0410 closed this Jul 17, 2020
@vinay0410 vinay0410 reopened this Jul 17, 2020
@vinay0410 vinay0410 mentioned this pull request Jul 17, 2020
Closed
@vinay0410 vinay0410 requested a review from corona10 July 18, 2020 10:12
corona10
corona10 requested changes Jul 19, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with all changes.
But please separate this PR into 2 PRs

  • PR for Increasing code coverage
  • Create a new issue for raising ValueError and create a new PR for this. (Please ping me this.)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vinay0410
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 July 19, 2020 11:39
@corona10 corona10 merged commit bfd0fbd into python:master Jul 19, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vinay0410 @arun-mani-j
bpo-38169: Increase code coverage for SharedMemory and ShareableList (p…
df246f6 
…ythonGH-16139)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@vinay0410 @shihai1991
bpo-38169: Increase code coverage for SharedMemory and ShareableList (p…
ebbe4cf 
…ythonGH-16139)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@vinay0410 @shihai1991
bpo-38169: Increase code coverage for SharedMemory and ShareableList (p…
9fd6631 
…ythonGH-16139)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@vinay0410
bpo-38169: Increase code coverage for SharedMemory and ShareableList (p…
65022bf 
…ythonGH-16139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinay0410 @bedevere-bot @corona10 @the-knights-who-say-ni