Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of patching in wave.py #17009

Merged

Conversation

micha2718l
Copy link
Contributor

This PR fixes the spelling of the word patching in the wave module.
pathing -> patching

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@micha2718l

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

Thanks for your time @micha2718l, and welcome to CPython! 😎

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me! I assume that you've seen the bot's message about the CLA?

@micha2718l
Copy link
Contributor Author

This looks like a good change to me! I assume that you've seen the bot's message about the CLA?

Good to hear!
I did, I followed the steps and filled it out, though the check yourself link still says not signed. I assume it is taking a bit of time to get through the system?

@brandtbucher
Copy link
Member

Yeah, as I understand it, it's checked by a human at the PSF. Just give it a full business day and the label should change.

The good news is, you only have to do this once. So future contributions should be easier!

@miss-islington
Copy link
Contributor

Thanks @micha2718l for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2019
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <[email protected]>
@bedevere-bot
Copy link

GH-17054 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2019
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <[email protected]>
@bedevere-bot
Copy link

GH-17055 is a backport of this pull request to the 3.7 branch.

@zware
Copy link
Member

zware commented Nov 5, 2019

Thanks for the patch @micha2718l, the review @brandtbucher, and for bringing it to my attention @ammaraskar!

miss-islington added a commit that referenced this pull request Nov 5, 2019
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <[email protected]>
miss-islington added a commit that referenced this pull request Nov 5, 2019
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <[email protected]>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants