-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling of patching in wave.py #17009
Fix spelling of patching in wave.py #17009
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Thanks for your time @micha2718l, and welcome to CPython! 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change to me! I assume that you've seen the bot's message about the CLA?
Good to hear! |
Yeah, as I understand it, it's checked by a human at the PSF. Just give it a full business day and the label should change. The good news is, you only have to do this once. So future contributions should be easier! |
Thanks @micha2718l for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
s/pathing/patching/ (cherry picked from commit 25fa3ec) Co-authored-by: Michael Haas <[email protected]>
GH-17054 is a backport of this pull request to the 3.8 branch. |
s/pathing/patching/ (cherry picked from commit 25fa3ec) Co-authored-by: Michael Haas <[email protected]>
GH-17055 is a backport of this pull request to the 3.7 branch. |
Thanks for the patch @micha2718l, the review @brandtbucher, and for bringing it to my attention @ammaraskar! |
s/pathing/patching/ (cherry picked from commit 25fa3ec) Co-authored-by: Michael Haas <[email protected]>
s/pathing/patching/ (cherry picked from commit 25fa3ec) Co-authored-by: Michael Haas <[email protected]>
s/pathing/patching/
s/pathing/patching/
This PR fixes the spelling of the word patching in the wave module.
pathing
->patching