bpo-39573: Clean up modules and headers to use Py_IS_TYPE #18521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
requested review from
1st1,
abalkin,
asvetlov,
methane,
pganssle,
rhettinger,
skrah and
tiran
as code owners
corona10
removed request for
methane,
1st1,
asvetlov,
tiran,
abalkin,
pganssle,
rhettinger and
skrah
vstinner
requested changes
Feb 17, 2020
Objects/typeobject.c
Outdated
| @@ -302,7 +302,7 @@ type_mro_modified(PyTypeObject *type, PyObject *bases) { | |||
| each subclass when their mro is recursively updated. | |||
| */ | |||
| Py_ssize_t i, n; | |||
| int custom = (Py_TYPE(type) != &PyType_Type); | |||
| int custom = Py_IS_TYPE(type, &PyType_Type); | |||
There was a problem hiding this comment.
I know that you made this mistake on purpose. Just to check that I really review your PRs! :-)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39573