Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-38662: ensurepip invokes pip via runpy (GH-18901) #18907

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 10, 2020

The ensurepip module now invokes pip via the runpy module.
Hence it is no longer tightly coupled with the internal API of the bundled
pip version, allowing easier updates to a newer pip version both
internally and for distributors.

This way, any changes to the internal pip API won't mean ensurepip needs to be
changed as well. Also, distributors can update their pip wheels independent on
CPython release schedule.

Co-Authored-By: Pradyun Gedam [email protected]
Co-Authored-By: Miro Hrončok [email protected]
(cherry picked from commit 88f82b2)

Co-authored-by: Miro Hrončok [email protected]

https://bugs.python.org/issue38662

The ensurepip module now invokes pip via the runpy module.
Hence it is no longer tightly coupled with the internal API of the bundled
pip version, allowing easier updates to a newer pip version both
internally and for distributors.

This way, any changes to the internal pip API won't mean ensurepip needs to be
changed as well. Also, distributors can update their pip wheels independent on
CPython release schedule.

Co-Authored-By: Pradyun Gedam <[email protected]>
Co-Authored-By: Miro Hrončok <[email protected]>
(cherry picked from commit 88f82b2)

Co-authored-by: Miro Hrončok <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@hroncok and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8d5c958 into python:3.7 Mar 10, 2020
@miss-islington miss-islington deleted the backport-88f82b2-3.7 branch March 10, 2020 21:34
@miss-islington
Copy link
Contributor Author

@hroncok and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants