Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40331: Increase test coverage for the statistics module #19608

Merged
merged 10 commits into from
May 13, 2020
60 changes: 60 additions & 0 deletions Lib/test/test_statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -1004,6 +1004,10 @@ def test_nan(self):
x = statistics._convert(nan, type(nan))
self.assertTrue(_nan_equal(x, nan))

def test_invalid_input_type(self):
with self.assertRaises(TypeError):
statistics._convert(None, float)


class FailNegTest(unittest.TestCase):
"""Test _fail_neg private function."""
Expand Down Expand Up @@ -1033,6 +1037,50 @@ def test_error_msg(self):
self.assertEqual(errmsg, msg)


class FindLteqTest(unittest.TestCase):
# Test _find_lteq private function.

def test_invalid_input_values(self):
for a, x in [
([], 1),
([1, 2], 3),
([1, 3], 2)
]:
with self.subTest(a=a, x=x):
with self.assertRaises(ValueError):
statistics._find_lteq(a, x)

def test_locate_successfully(self):
for a, x, expected_i in [
([1, 1, 1, 2, 3], 1, 0),
([0, 1, 1, 1, 2, 3], 1, 1),
([1, 2, 3, 3, 3], 3, 2)
]:
with self.subTest(a=a, x=x):
self.assertEqual(expected_i, statistics._find_lteq(a, x))


class FindRteqTest(unittest.TestCase):
# Test _find_rteq private function.

def test_invalid_input_values(self):
for a, l, x in [
([1], 2, 1),
([1, 3], 0, 2)
]:
with self.assertRaises(ValueError):
statistics._find_rteq(a, l, x)

def test_locate_successfully(self):
for a, l, x, expected_i in [
([1, 1, 1, 2, 3], 0, 1, 2),
([0, 1, 1, 1, 2, 3], 0, 1, 3),
([1, 2, 3, 3, 3], 0, 3, 4)
]:
with self.subTest(a=a, l=l, x=x):
self.assertEqual(expected_i, statistics._find_rteq(a, l, x))


# === Tests for public functions ===

class UnivariateCommonMixin:
Expand Down Expand Up @@ -1476,6 +1524,18 @@ def test_negative_error(self):
with self.subTest(values=values):
self.assertRaises(exc, self.func, values)

def test_invalid_type_error(self):
# Test error is raised when input contains invalid type(s)
for data in [
['3.14'], # single string
['1', '2', '3'], # multiple strings
[1, '2', 3, '4', 5], # mixed strings and valid integers
[2.3, 3.4, 4.5, '5.6'] # only one string and valid floats
]:
with self.subTest(data=data):
with self.assertRaises(TypeError):
self.func(data)

def test_ints(self):
# Test harmonic mean with ints.
data = [2, 4, 4, 8, 16, 16]
Expand Down