Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38787: update docs of structures.rst and code style of _testmultiphase.c #19980

Merged
merged 1 commit into from
May 7, 2020
Merged

bpo-38787: update docs of structures.rst and code style of _testmultiphase.c #19980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/c-api/structures.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Implementing functions and methods
The function signature is::

PyObject *PyCFunction(PyObject *self,
PyObject *const *args);
PyObject *args);

.. c:type:: PyCFunctionWithKeywords

Expand All @@ -159,7 +159,7 @@ Implementing functions and methods
The function signature is::

PyObject *PyCFunctionWithKeywords(PyObject *self,
PyObject *const *args,
PyObject *args,
PyObject *kwargs);


Expand Down
16 changes: 6 additions & 10 deletions Modules/_testmultiphase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,16 +820,12 @@ static PyModuleDef_Slot meth_state_access_slots[] = {
};

static PyModuleDef def_meth_state_access = {
PyModuleDef_HEAD_INIT, /* m_base */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually accept the style changing PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for this PR on purpose :-) Read comments starting at: #19936 (review)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see :)

"_testmultiphase_meth_state_access", /* m_name */
PyDoc_STR("Module testing access"
" to state from methods."),
sizeof(meth_state), /* m_size */
NULL, /* m_methods */
meth_state_access_slots, /* m_slots */
0, /* m_traverse */
0, /* m_clear */
0, /* m_free */
PyModuleDef_HEAD_INIT,
.m_name = "_testmultiphase_meth_state_access",
.m_doc = PyDoc_STR("Module testing access"
" to state from methods."),
.m_size = sizeof(meth_state),
.m_slots = meth_state_access_slots,
};

PyMODINIT_FUNC
Expand Down