-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bpo-40137: Use pep573 in functools extension module. #20055
Conversation
There have a problem what petr have mentioned in #19982: This also only works because the iterator type is not subclassable.( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.
It seems like the _functools will have to wait until the PEP 573 is extended.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
You are right, the type have |
https://bugs.python.org/issue40137