Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41003: Fix test_copyreg when numpy is installed #20935

Merged
merged 2 commits into from
Jun 17, 2020
Merged

bpo-41003: Fix test_copyreg when numpy is installed #20935

merged 2 commits into from
Jun 17, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 17, 2020

Fix test_copyreg when numpy is installed: test.pickletester now
saves/restores warnings.filters when importing numpy, to ignore
filters installed by numpy.

Add the save_restore_warnings_filters() function to the
test.support.warnings_helper module.

https://bugs.python.org/issue41003

Fix test_copyreg when numpy is installed: test.pickletester now
saves/restores warnings.filters when importing numpy, to ignore
filters installed by numpy.

Add the save_restore_warnings_filters() function to the
test.support.warnings_helper module.
@vstinner
Copy link
Member Author

This change should be backport to 3.8 and 3.9 branches, but 3.9 doesn't have the test.support.warnings_helper module. I will backport the change manually.

@vstinner vstinner merged commit 8362893 into python:master Jun 17, 2020
@vstinner vstinner deleted the save_restore_warnings_filters branch June 17, 2020 16:07
@vstinner vstinner restored the save_restore_warnings_filters branch June 17, 2020 16:16
@vstinner vstinner deleted the save_restore_warnings_filters branch June 17, 2020 16:17
vstinner added a commit that referenced this pull request Jun 17, 2020
)

Fix test_copyreg when numpy is installed: test.pickletester now
saves/restores warnings.filters when importing numpy, to ignore
filters installed by numpy.

Add the save_restore_warnings_filters() function to the
test.support.warnings_helper module.

(cherry picked from commit 8362893)
vstinner added a commit that referenced this pull request Jun 17, 2020
) (GH-20946)

Fix test_copyreg when numpy is installed: test.pickletester now
saves/restores warnings.filters when importing numpy, to ignore
filters installed by numpy.

Add the save_restore_warnings_filters() function to the
test.support.warnings_helper module.

(cherry picked from commit 8362893)
(cherry picked from commit b39d41b)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
Fix test_copyreg when numpy is installed: test.pickletester now
saves/restores warnings.filters when importing numpy, to ignore
filters installed by numpy.

Add the save_restore_warnings_filters() function to the
test.support.warnings_helper module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants