Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41009: fix requires_OS_version() class decorator #20942

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 17, 2020

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue41009

Automerge-Triggered-By: @tiran

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
Signed-off-by: Christian Heimes <[email protected]>
Signed-off-by: Christian Heimes <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.9

@miss-islington miss-islington self-assigned this Jun 17, 2020
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.8

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.7

@tiran tiran added needs backport to 3.9 only security fixes and removed needs backport to 3.7 needs backport to 3.9 only security fixes labels Jun 17, 2020
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.9

tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
…20942)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 17, 2020
@bedevere-bot
Copy link

GH-20947 is a backport of this pull request to the 3.9 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
…20942)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
…20942)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
ned-deily pushed a commit that referenced this pull request Jun 25, 2020
…GH-20949)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
miss-islington pushed a commit that referenced this pull request Jun 25, 2020
…GH-20947)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
miss-islington pushed a commit that referenced this pull request Jun 25, 2020
…GH-20948)

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants