Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41100: test fixes for Mac OS 11 #21266

Closed

Conversation

lawrence-danna-apple
Copy link
Contributor

@lawrence-danna-apple lawrence-danna-apple commented Jul 1, 2020

test_platform: add arm64 to list of expected arches on Mac OS

test_distutils: don't assume Mac OS major version is always 10

https://bugs.python.org/issue41100

test_platform: add arm64 to list of expected arches on Mac OS

test_distutils: don't assume Mac OS major version is always 10
@@ -0,0 +1 @@
test fixes for Mac OS 11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if a NEWS is necessary for tests fixes. But I would like to wait for a core developer opinion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot made me do it. I don't think i have permission to add the label necessary to skip news.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lawrence-danna-apple I added the label for skip news.

Lib/distutils/tests/test_build_ext.py Outdated Show resolved Hide resolved
@ned-deily
Copy link
Member

Thanks for the PR. It has been rolled up into GH-22855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants