-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41325: Document unittest mock.call_args
change in 3.8
#21525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uSpike
force-pushed
the
document_unittest_mock_38
branch
from
July 17, 2020 17:28
29a297b
to
6cc7b5b
Compare
uSpike
changed the title
bpo41325: Document unittest
bpo-41325: Document unittest Jul 17, 2020
mock.call_args
change in 3.8mock.call_args
change in 3.8
tirkarthi
added
skip news
needs backport to 3.8
needs backport to 3.9
only security fixes
labels
Jul 18, 2020
tirkarthi
approved these changes
Jul 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Thanks @uSpike for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2020
…ct (pythonGH-21525) (cherry picked from commit 9b01c59) Co-authored-by: Jordan Speicher <[email protected]>
GH-21530 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2020
…ct (pythonGH-21525) (cherry picked from commit 9b01c59) Co-authored-by: Jordan Speicher <[email protected]>
GH-21531 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 18, 2020
…ct (GH-21525) (cherry picked from commit 9b01c59) Co-authored-by: Jordan Speicher <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jul 18, 2020
…ct (GH-21525) (cherry picked from commit 9b01c59) Co-authored-by: Jordan Speicher <[email protected]>
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple documentation addition to describe that
args
andkwargs
were added to unittest mockmock.call_args
in python 3.8.https://bugs.python.org/issue41325