Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41325: Document unittest mock.call_args change in 3.8 #21525

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

uSpike
Copy link
Contributor

@uSpike uSpike commented Jul 17, 2020

This is a simple documentation addition to describe that args and kwargs were added to unittest mock mock.call_args in python 3.8.

https://bugs.python.org/issue41325

@uSpike uSpike force-pushed the document_unittest_mock_38 branch from 29a297b to 6cc7b5b Compare July 17, 2020 17:28
@uSpike uSpike changed the title bpo41325: Document unittest mock.call_args change in 3.8 bpo-41325: Document unittest mock.call_args change in 3.8 Jul 17, 2020
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi merged commit 9b01c59 into python:master Jul 18, 2020
@miss-islington
Copy link
Contributor

Thanks @uSpike for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2020
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 18, 2020
@bedevere-bot
Copy link

GH-21530 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2020
@bedevere-bot
Copy link

GH-21531 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jul 18, 2020
…ct (GH-21525)

(cherry picked from commit 9b01c59)

Co-authored-by: Jordan Speicher <[email protected]>
miss-islington added a commit that referenced this pull request Jul 18, 2020
…ct (GH-21525)

(cherry picked from commit 9b01c59)

Co-authored-by: Jordan Speicher <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants