bpo-41100: bugfix, arm64 Mac OS, missing #include <AvailabilityMacros.h> #21588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAC_OS_X_VERSION_MAX_ALLOWED is defined in this header. Because it is not included nsexeclength is defined as the wrong type, causing an incompatible pointer to be passed to _NSGetExecutablePath
kk456852
approved these changes
Jul 23, 2020
BoboTiG
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Thanks, that easy fix would solve that GCC warning:
gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I./Include/internal -I. -I./Include -DPy_BUILD_CORE_BUILTIN -c ./Modules/_operator.c -o Modules/_operator.o
./Modules/getpath.c:942:40: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'uint32_t *' (aka 'unsigned int *') [-Wincompatible-pointer-types]
if (_NSGetExecutablePath(execpath, &nsexeclength) != 0
^~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/mach-o/dyld.h:98:54: note: passing argument to parameter 'bufsize' here
extern int _NSGetExecutablePath(char* buf, uint32_t* bufsize) __OSX_AVAILABLE_STARTING(__MAC_10_2, __IPHONE_2_0);
^
| @@ -0,0 +1 @@ | |||
| fix a bug in getpath.c for arm64 Mac OS | |||
There was a problem hiding this comment.
I would rework that sentence as this is not only for ARM64 but x86_64 too:
Suggested change
| fix a bug in getpath.c for arm64 Mac OS | |
| Fixed a bug in `Modules/getpath.c` for macOS 11. Patch by Lawrence D'Anna. |
|
Thanks for the PR. It has been superseded by changes in PR 22855 which remove the need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAC_OS_X_VERSION_MAX_ALLOWED is defined in this header. Because it is
not included nsexeclength is defined as the wrong type, causing an
incompatible pointer to be passed to _NSGetExecutablePath on arm64
https://bugs.python.org/issue41100