Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741 port zlib module to multi-phase init #21995

Merged
merged 5 commits into from
Sep 7, 2020
Merged

bpo-1635741 port zlib module to multi-phase init #21995

merged 5 commits into from
Sep 7, 2020

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Aug 29, 2020 •
edited by bedevere-bot
Loading

@koubaa
Copy link
Contributor Author

koubaa commented Aug 29, 2020

I don't get the CI failure - I ran clinic on zlibmodule and it didn't show any differences. Do I have to change the line endings or something like that?

@koubaa
Copy link
Contributor Author

koubaa commented Sep 2, 2020

@shihai1991 @vstinner please review

vstinner
vstinner reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change looks correct, but I have a few comments.

Misc/NEWS.d/next/Core and Builtins/2020-08-28-20-54-04.bpo-1635741.7ijlcI.rst Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! The updated PR is way better, especially with defining_class. New review, likely the last one.

Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
shihai1991
shihai1991 reviewed Sep 5, 2020
View reviewed changes
Modules/zlibmodule.c Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Sep 6, 2020
View reviewed changes
Modules/zlibmodule.c Outdated Show resolved Hide resolved
Modules/zlibmodule.c Outdated Show resolved Hide resolved
@vstinner vstinner merged commit 1aaa21f into python:master Sep 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
00b300c 
* origin/master: (1373 commits)
  bpo-1635741: Port mashal module to multi-phase init (python#22149)
  bpo-1635741: Port _string module to multi-phase init (pythonGH-22148)
  bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134)
  bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139)
  bpo-41732: add iterator to memoryview (pythonGH-22119)
  bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909)
  bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511)
  bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092)
  bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986)
  bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051)
  bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050)
  bpo-1635741 port zlib module to multi-phase init (pythonGH-21995)
  [doc] Add link to Generic in typing (pythonGH-22125)
  bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123)
  bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818)
  closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110)
  [doc] Fix padding in some typing definitions (pythonGH-22114)
  Fix documented Python version for venv --upgrade-deps (pythonGH-22113)
  bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
  bpo-41687: Fix sendfile implementation to work with Solaris (python#22040)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa
bpo-1635741 port zlib module to multi-phase init (pythonGH-21995)
0be5f5f 
Port the zlib extension module to multi-phase initialization (PEP 489).
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@shihai1991 shihai1991 shihai1991 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koubaa @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot