-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41111: Build limited C API without Py_TRACE_REFS macro. #25180
Conversation
setup.py
Outdated
# Limited C API | ||
self.add(Extension('xxlimited', ['xxlimited.c'])) | ||
self.add(Extension('xxlimited_35', ['xxlimited_35.c'])) | ||
# Build limited C API without Py_TRACE_REFS macro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is wrong. You should say that the limited C API is not compatible with the Py_TRACE_REFS macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Updated :)
Thanks, I merged your fix. Without this fix, xxlimited failed to build on the AMD64 Arch Linux TraceRefs 3.x buildbot. Example:
https://buildbot.python.org/all/#/builders/484/builds/525 But it's not treated as an error: the compilation is displayed as a success. Moreover, test_xxlimited is simply skipped if xxlimited is missing. This change should fix it. |
Thanks Victor for your review & merge :) |
https://bugs.python.org/issue41111