Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42238: [doc]: Hide false positive in make suspicious. #29636

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Nov 19, 2021

@JulienPalard
Copy link
Member Author

Original PR (#29389) has been backported to 3.9 and 3.10 so I'll backport this to 3.9 and 3.10 too.

@AlexWaygood
Copy link
Member

Original PR (#29389) has been backported to 3.9 and 3.10 so I'll backport this to 3.9 and 3.10 too.

I think @ambv already applied this to 3.9/3.10:

(Sorry for the bother — thanks for fixing!)

@ambv ambv removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 19, 2021
@ambv
Copy link
Contributor

ambv commented Nov 19, 2021

@JulienPalard, since we're no longer running make suspicious in CI for main per your own change (GH-26575), should we just stop caring about make suspicious at all?

@ambv ambv merged commit d32316a into python:main Nov 19, 2021
@JulienPalard JulienPalard deleted the mdk-suspicious branch November 20, 2021 00:58
@JulienPalard
Copy link
Member Author

JulienPalard commented Nov 20, 2021

@JulienPalard, since we're no longer running make suspicious in CI for main per your own change (GH-26575), should we just stop caring about make suspicious at all?

Soon, yes. The idea is I'm tracking closely make suspicious in bpo-42238 to see if there's true positives that I can implement in rstlint.py. It allowed me to add a few new things in rstlint:

and we do ensure rstlint in the CI as it make no false positives.

So « soon » rstlint should catch all the true positives of make suspicious, leaving only false positives for make suspicious.

This day I'll just drop it, and really stop caring about it.

Up to this day I prefer having an up-to-date susp-ignored.csv, so I can easily monitor new alerts.

@JulienPalard
Copy link
Member Author

(But I only watch master so backporting can be ignored, yes)

@AlexWaygood
Copy link
Member

and we do ensure rstlint in the CI as it make no false positives.

Arguably rstlint did have a few false positives in this PR 🙂 (but maybe I'm just too backtick-happy!)

@JulienPalard
Copy link
Member Author

Arguably rstlint did have a few false positives in this PR slightly_smiling_face (but maybe I'm just too backtick-happy!)

This is a really interesting information, TIL, thanks! I'll have to look at it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants