bpo-46606: Reduce stack usage of getgroups and setgroups #31073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGROUPS_MAX was 32 before Linux 2.6.4 but 65536 since Linux 2.6.4.
|
Looks like this logic is from 1999! Line 1739 in c968092 Operating systems seem to have dramatically increased NGROUPS_MAX since then: https://www.j3e.de/ngroups.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGROUPS_MAX was 32 before Linux 2.6.4 but 65536 since Linux 2.6.4.
This reduce stack usage more than 200KB. It means less risk of C stackoverflow.
https://bugs.python.org/issue46606