bpo-46586: Fix documentation links #31216
Conversation
Incorrectly pointed to built-in the property() function as mentioned in python#46586
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
ethanfurman
changed the title
Doc/library/sys.rst
Outdated
| @@ -545,15 +545,15 @@ always available. | |||
| | :const:`mant_dig` | DBL_MANT_DIG | float precision: the number of base-``radix`` | | |||
| | | | digits in the significand of a float | | |||
| +---------------------+----------------+--------------------------------------------------+ | |||
| | :const:`max` | DBL_MAX | maximum representable positive finite float | | |||
| | :const:`!max` | DBL_MAX | maximum representable positive finite float | | |||
There was a problem hiding this comment.
I think this is better done in a separate PR, so we can backport to the other bugfix branches.
There was a problem hiding this comment.
I see, so I guess that will require opening another issue and then the corresponding PR? Should I revert this commit here then?
There was a problem hiding this comment.
Yes, revert the commit here. It doesn't need an issue; trivial docs fixes don't need an issue. You can just attach the second PR to the same issue.
There was a problem hiding this comment.
Also, based on @zware's comment on the bug, it's going to be better to change these to just put max in double backticks, since they aren't supposed to link anywhere.
There was a problem hiding this comment.
That comment was @merwok, not me 😉. I agree with him, though.
| @@ -0,0 +1 @@ | |||
| Fix enum.property link to point to the enum page rather than the built-in property() page | |||
There was a problem hiding this comment.
Not sure this needs a NEWS entry at all.
There was a problem hiding this comment.
Yeah sorry about that, I used blurb-it for the first time and by the time I was done, I saw that the skip-news label had been added. Should I just make another commit to remove this file?
This reverts commit 64f5b1d.
Incorrectly pointed to built-in the property() function as mentioned in #46586
https://bugs.python.org/issue46586