Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46955: Expose asyncio.base_events.Server as asyncio.Server #31760

Merged
merged 2 commits into from
Mar 8, 2022
Merged

bpo-46955: Expose asyncio.base_events.Server as asyncio.Server #31760

merged 2 commits into from
Mar 8, 2022

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Mar 8, 2022

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.Server with the actual implementation

https://bugs.python.org/issue46955

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@vringar

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 8, 2022

Hi, thanks for the PR — it looks like there's a typo in your PR title; it should be 46955 instead of 46995 :) if you change the title, the CI check for a BPO issue will go green

@vringar vringar changed the title bpo-46995: Expose asyncio.base_events.Server as asyncio.Server bpo-46955: Expose asyncio.base_events.Server as asyncio.Server Mar 8, 2022
@asvetlov asvetlov added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed skip news labels Mar 8, 2022
@asvetlov asvetlov merged commit da80d6b into python:main Mar 8, 2022
@miss-islington
Copy link
Contributor

Thanks @vringar for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vringar and @asvetlov, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da80d6b2f3beff519cb1457d5e055168c89f7224 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
…nGH-31760)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
@bedevere-bot
Copy link

GH-31773 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 8, 2022
@asvetlov asvetlov added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Mar 8, 2022
@miss-islington
Copy link
Contributor

Thanks @vringar for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-31774 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 8, 2022
asvetlov pushed a commit to asvetlov/cpython that referenced this pull request Mar 8, 2022
…pythonGH-31760)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
…nGH-31760)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
miss-islington added a commit that referenced this pull request Mar 8, 2022
)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
miss-islington added a commit that referenced this pull request Mar 8, 2022
)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
@vringar vringar deleted the export-asyncio-server branch March 8, 2022 22:24
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…nGH-31760)

This change aligns the documentation at https://docs.python.org/3/library/asyncio-eventloop.htmlGH-asyncio.Server
with the actual implementation

Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit da80d6b)

Co-authored-by: Stefan Zabka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants