Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-28334: netrc() now uses expanduser() to find .netrc file #4537

Merged
merged 3 commits into from
Nov 25, 2017

Conversation

berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Nov 24, 2017

Previously, netrc.netrc() was raised an exception if
$HOME is not set.

Authored-By: Dimitri Merejkowsky <[email protected]>

https://bugs.python.org/issue28334

Also add more tests to check that proper exceptions are raised
@berkerpeksag berkerpeksag reopened this Nov 24, 2017
@berkerpeksag berkerpeksag changed the title [DO NOT MERGE] bpo-28334: fix netrc not working when $HOME is not set bpo-28334: fix netrc not working when $HOME is not set Nov 25, 2017
@berkerpeksag berkerpeksag changed the title bpo-28334: fix netrc not working when $HOME is not set bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc Nov 25, 2017
@berkerpeksag berkerpeksag changed the title bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc bpo-28334: netrc() now uses expanduser() to find .netrc file Nov 25, 2017
@berkerpeksag berkerpeksag merged commit 8d9bb11 into python:master Nov 25, 2017
@berkerpeksag berkerpeksag deleted the 28334-netrc branch November 25, 2017 10:37
sloria added a commit to sloria/tinynetrc that referenced this pull request Jan 12, 2018
Avoids an exception when $HOME is not set.
This behavior matches the behavior in Python 3.7
See python/cpython#4537

close #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants